02-client-refactor: rename update to UpdateState for 07-tendermint #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename 07-tendermint update function to UpdateState add pruneOldestConsensusState function add check for duplicate update
colin-axner
commented
Mar 14, 2022
Comment on lines
+276
to
+278
| if pruneError != nil { | ||
| panic(pruneError) | ||
| } |
There was a problem hiding this comment.
I think we should just panic within the iterate function, but I can fix in a followup pr
colin-axner
commented
Mar 16, 2022
| testCases := []struct { | ||
| name string | ||
| malleate func() | ||
| expResult func() |
There was a problem hiding this comment.
I find it useful to add a expected results callback for test cases which need to check unique state changes
There was a problem hiding this comment.
Nice, I could see this being a useful approach for testing other state updates. ICS29 tests come to mind! :)
damiannolan
approved these changes
Mar 17, 2022
| // pruneOldestConsensusState will retrieve the earliest consensus state for this clientID and check if it is expired. If it is, | ||
| // that consensus state will be pruned from store along with all associated metadata. This will prevent the client store from | ||
| // becoming bloated with expired consensus states that can no longer be used for updates and packet verification. | ||
| func (cs ClientState) pruneOldestConsensusState(ctx sdk.Context, cdc codec.BinaryCodec, clientStore sdk.KVStore) { |
There was a problem hiding this comment.
nit: add some logical spacing between code in this function.
There was a problem hiding this comment.
sounds good. Copied from existing code, but agree it could use spacing
| testCases := []struct { | ||
| name string | ||
| malleate func() | ||
| expResult func() |
There was a problem hiding this comment.
Nice, I could see this being a useful approach for testing other state updates. ICS29 tests come to mind! :)
seantking
approved these changes
Mar 24, 2022
seunlanlege
pushed a commit
to ComposableFi/ibc-go
that referenced
this pull request
Aug 9, 2022
…osmos#1117) * rename update to UpdateState rename 07-tendermint update function to UpdateState add pruneOldestConsensusState function add check for duplicate update * fix: duplicate update check was performing incorrect logic * update godoc * add UpdateState tests * update godoc * chore: fix code spacing Co-authored-by: Sean King <[email protected]>
CosmosCar
pushed a commit
to caelus-labs/ibc-go
that referenced
this pull request
Nov 6, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview I did a quick audit of the code for infinite for loops to catch any remaining places where we might be hanging after a shutdown. This PR adds some comments to explain some test helpers and adds two select statements that watch for cancellation of subscriptions to help with a cleaner shutdown. <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> closes cosmos#1069 ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #879
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes